Consolidate structs / Consistent `manifests` overrides

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies

Apache License 2.0

29 stars 31 forks source link

Consolidate structs / Consistent `manifests` overrides #71

Closed dhaiducek closed 2 years ago

dhaiducek commented 2 years ago

This PR is twofold:

Implement PolicyOptions and ConfigurationPolicyOptions, which folds keys into a single struct that can be used in the PolicyDefaults, Policy, and Manifests structs.
The consolidation brings consistency to overrides in Manifests that was missing previously, so this also adds the required validation and overrides there

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

97.6% Coverage
0.0% Duplication

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/policy-generator-plugin/blob/main/OWNERS)~~ [dhaiducek,mprahl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment