search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

OCPBUGS-2200: Add remediationAction at the Policy spec level #81

Closed tliu2021 closed 1 year ago

tliu2021 commented 2 years ago

Signed-off-by: Tao Liu tali@redhat.com

mprahl commented 2 years ago

@tliu2021 thanks so much for the contribution! Could you please address the linting failures?

Also, could you please restructure your commit message to follow our standards? https://github.com/open-cluster-management-io/community/blob/main/sig-policy/contribution-guidelines.md#commit-messages

You can look at the following commits as examples: https://github.com/stolostron/policy-generator-plugin/commit/88a386a35a2961edeb1a8cb9120e412745166173 https://github.com/stolostron/policy-generator-plugin/commit/cde84ee52ff69df01d1fbbdc37acaaf5332b5c5a

tliu2021 commented 2 years ago

The commit message has been updated and linting failures are fixed.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, tliu2021

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/stolostron/policy-generator-plugin/blob/main/OWNERS)~~ [mprahl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mprahl commented 1 year ago

/cherry-pick v1.9

openshift-cherrypick-robot commented 1 year ago

@mprahl: once the present PR merges, I will cherry-pick it on top of v1.9 in a new PR and assign it to you.

In response to [this](https://github.com/stolostron/policy-generator-plugin/pull/81#issuecomment-1306050794): >/cherry-pick v1.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 year ago

@mprahl: new pull request created: #83

In response to [this](https://github.com/stolostron/policy-generator-plugin/pull/81#issuecomment-1306050794): >/cherry-pick v1.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.