search

open-cluster-management-io / policy-generator-plugin

A Kustomize generator plugin to generate Open Cluster Management policies
Apache License 2.0
29 stars 31 forks source link

Make default binding name optional #9

Closed dhaiducek closed 3 years ago

dhaiducek commented 3 years ago

Rather than running an initial validation on the placementBindingDefaults.name, this moves the logic deeper, leveraging the new placement flows to determine whether a default binding name is strictly necessary.

mprahl commented 3 years ago

@dhaiducek this looks good. Could you please rebase on the latest main branch and add a unit test for this?

dhaiducek commented 3 years ago

Yes! I'll work on a unit test to cover the other PR also.

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management/policy-generator-plugin/blob/main/OWNERS)~~ [dhaiducek,mprahl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment