Closed willkutler closed 1 year ago
/hold refactoring to fix code smells
/unhold
@mprahl second round of review changes are in the latest commit
@mprahl new review is done
@willkutler this looks great. Just fix that one typo and squash your commits. I'll approve it afterwards.
Kudos, SonarCloud Quality Gate passed!
@mprahl @dhaiducek I think this should be good to go
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mprahl, willkutler
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Placements can now be generated by nesting a full labelSelector or clusterSelector YAML under the
placement
key, in addition to the legacy method of listing key/value pairs underplacement
. This allows users to specify multiple clusters in the values array of a placement or placementRule, and to use matchLabels instead of matchExpressions (only supported by placement).Signed-off-by: Will Kutler wkutler@redhat.com