search

open-cluster-management-io / registration-operator

Minimum cluster registration and work
Apache License 2.0
58 stars 58 forks source link

limit secret permissions #350

Closed zhiweiyin318 closed 1 year ago

zhiweiyin318 commented 1 year ago

/assign @qiujian16 /assign @xuezhaojun

qiujian16 commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration-operator/blob/main/OWNERS)~~ [qiujian16,zhiweiyin318] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xuezhaojun commented 1 year ago

/lgtm

xuezhaojun commented 1 year ago

/hold

hosted mode part looks good to me, unhold when you think the rest parts are ready.

zhiweiyin318 commented 1 year ago

/unhold