search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

deploy control plane and agent in two clusters #182

Closed zhujian7 closed 2 years ago

zhujian7 commented 2 years ago

This PR supports deploying registration control plane and agent in two separate clusters and in different namespaces. It is good for new guys to understand the registration.

Signed-off-by: zhujian jiazhu@redhat.com

cc @qiujian16 @skeeey

zhujian7 commented 2 years ago

// defaultSpokeComponentNamespace is the default namespace in which the spoke agent is deployed defaultSpokeComponentNamespace = "open-cluster-management"

I am not quite sure if https://github.com/open-cluster-management-io/registration/blob/main/pkg/spoke/spokeagent.go#L45 should be changed to "open-cluster-management-agent" Is this defaultSpokeComponentNamespace only useful for tests?

skeeey commented 2 years ago

// defaultSpokeComponentNamespace is the default namespace in which the spoke agent is deployed defaultSpokeComponentNamespace = "open-cluster-management"

I am not quite sure if https://github.com/open-cluster-management-io/registration/blob/main/pkg/spoke/spokeagent.go#L45 should be changed to "open-cluster-management-agent" Is this defaultSpokeComponentNamespace only useful for tests?

We also use open-cluster-management-agent as the default namespace in registration-operator, so I think we may change this to keep the consistent

/cc @qiujian16 what's your opinion?

qiujian16 commented 2 years ago

yes, I think we should change it to open-cluster-management-agent

qiujian16 commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment