search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

add controller to set default clusterset label #202

Closed ycyaoxdu closed 2 years ago

ycyaoxdu commented 2 years ago

add a controller to set default cluster set label for managed clusters which not set cluster set label. the label will be cluster.open-cluster-management.io/clusterset:default

Signed-off-by: ycyaoxdu yaoyuchen0626@163.com

ycyaoxdu commented 2 years ago

/assign @ldpliu

ldpliu commented 2 years ago

please change file name like: a_b_c

ldpliu commented 2 years ago

I am not sure if it's better to put the logic to current managedcluster controller.(pkg/hub/managedcluster/controller.go)

ldpliu commented 2 years ago

/cc @elgnay

skeeey commented 2 years ago

I am not sure if it's better to put the logic to current managedcluster controller.(pkg/hub/managedcluster/controller.go)

I don't think it's a better way to put the logic to the managedcluster controller, using an independent controller make the logic more clear，and managedcluster controller is used to handle accept a managed cluster,

ycyaoxdu commented 2 years ago

/hold

ycyaoxdu commented 2 years ago

@elgnay thanks a lot for help :)

ycyaoxdu commented 2 years ago

/cc @qiujian16 @ldpliu

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ycyaoxdu commented 2 years ago

/unhold