search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

add disable annotation detection for default managed cluster set #210

Closed ycyaoxdu closed 2 years ago

ycyaoxdu commented 2 years ago

add disable annotation detection for default managed cluster set, ensuring users have property to modify default managed cluster set spec

Signed-off-by: ycyaoxdu yaoyuchen0626@163.com

ycyaoxdu commented 2 years ago

@qiujian16 @ldpliu please help to review.

qiujian16 commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment