search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

begin to remove resources on Hub when there is only api-resource-cleanup finalizer #211

Closed zhiweiyin318 closed 2 years ago

zhiweiyin318 commented 2 years ago

when the mcl is deleting, the addon with pre-delete needs to deploy pre-delete manifestWork on the cluster to do some cleanup job. in this case, we should begin to remove resources until all of finalizers expect api-resource-cleanup are removed .

Signed-off-by: Zhiwei Yin zyin@redhat.com

zhiweiyin318 commented 2 years ago

/assign @qiujian16

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhiweiyin318 To complete the pull request process, please ask for approval from qiujian16 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment