search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

Memory usage keeps increasing when add-on registration config changes frequently #219

Closed elgnay closed 1 year ago

elgnay commented 2 years ago

When registration config of an add-on changes frequently, for example 1 time per second, registration-agent will create a new CSR based on the new config on hub cluster. The number of CSRs may increase quickly. Since the registration-agent caches all those CSRs, that may cause the memory usage keep increasing. A mechanism is needed to limit the rate of CSR creation for each addon.

qiujian16 commented 2 years ago

/kind bug

qiujian16 commented 1 year ago

we have added a limit on csr that can be created.

/close

openshift-ci[bot] commented 1 year ago

@qiujian16: Closing this issue.

In response to [this](https://github.com/open-cluster-management-io/registration/issues/219#issuecomment-1308859952): >we have added a limit on csr that can be created. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.