search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

fix clusterset sync issue #234

Closed elgnay closed 2 years ago

elgnay commented 2 years ago

Signed-off-by: Yang Le yangle@redhat.com

elgnay commented 2 years ago

/hold

elgnay commented 2 years ago

/assign @qiujian16 /assign @skeeey

elgnay commented 2 years ago

/unhold

elgnay commented 2 years ago

I think we should add an integration test for this

We have already had the integration test case to cover this issue, but the out-of-sync happens occasionally. I update the test case to repeat the same testing 10 times.

qiujian16 commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment