search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

update qps and burst for webhook #249

Closed ldpliu closed 2 years ago

ldpliu commented 2 years ago

Signed-off-by: ldpliu daliu@redhat.com

ldpliu commented 2 years ago

/assign @qiujian16 @elgnay

ldpliu commented 2 years ago

maybe we should put this as flag and set some default value

it's not easy to add the qps and burst flag for webhook. As current webhook use the o.RecommendedOptions https://github.com/open-cluster-management-io/registration/blob/fd33e20727c4d295f49b18c249d279369426c230/pkg/cmd/webhook/webhook.go#L46

qiujian16 commented 2 years ago

I think you can create another AddFlags options for this, right?

ldpliu commented 2 years ago

I think you can create another AddFlags options for this, right?

Done, please help to review again.

ldpliu commented 2 years ago

/hold need test

ldpliu commented 2 years ago

/unhold tested

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldpliu, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ldpliu commented 2 years ago

/unhold