Closed ldpliu closed 2 years ago
/assign @qiujian16 @elgnay
maybe we should put this as flag and set some default value
it's not easy to add the qps and burst flag for webhook.
As current webhook use the o.RecommendedOptions
https://github.com/open-cluster-management-io/registration/blob/fd33e20727c4d295f49b18c249d279369426c230/pkg/cmd/webhook/webhook.go#L46
I think you can create another AddFlags options for this, right?
I think you can create another AddFlags options for this, right?
Done, please help to review again.
/hold need test
/unhold tested
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ldpliu, qiujian16
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/unhold
Signed-off-by: ldpliu daliu@redhat.com