search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

remove add default set label controller #250

Closed ldpliu closed 2 years ago

ldpliu commented 2 years ago

Signed-off-by: ldpliu daliu@redhat.com

ldpliu commented 2 years ago

/cc @qiujian16 @elgnay

ldpliu commented 2 years ago

we should also remove the rbac rules, right?

Removed https://github.com/open-cluster-management-io/registration/pull/250/files#diff-68752c39408458ef5dc35f2232378e0f2848f1ff035af41ab6a5fa57eb5831acL64 And will submit another pr to remove this in registration-oprator after this pr merged.

qiujian16 commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldpliu, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment