search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

add global clusterset #251

Closed ldpliu closed 2 years ago

ldpliu commented 2 years ago

Signed-off-by: ldpliu daliu@redhat.com https://github.com/stolostron/backlog/issues/22994

ldpliu commented 2 years ago

/cc @qiujian16 @elgnay Please help to review it I am not sure if we should identify the autoUpdateAnnotation cluster.open-cluster-management.io/autoupdate for global set. https://github.com/open-cluster-management-io/registration/pull/251/files#diff-fc2d0a93df947afba08cbd4f0db61e2abf4429ff9e20b48489a1f9776c1711bcR117

openshift-ci[bot] commented 2 years ago

@ldpliu: GitHub didn't allow me to request PR reviews from the following users: to, review, it, Please.

Note that only open-cluster-management-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/open-cluster-management-io/registration/pull/251#issuecomment-1148076816): >/cc @qiujian16 @elgnay Please help to review it >I am not sure if we should identify the `autoUpdateAnnotation` `cluster.open-cluster-management.io/autoupdate` for global set. >https://github.com/open-cluster-management-io/registration/pull/251/files#diff-fc2d0a93df947afba08cbd4f0db61e2abf4429ff9e20b48489a1f9776c1711bcR117 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qiujian16 commented 2 years ago

/approve /lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldpliu, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment