search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

use registration feature gates constants & variabels which in api repo #253

Closed ivan-cai closed 2 years ago

ivan-cai commented 2 years ago

Signed-off-by: ivan-cai caijing.cai@alibaba-inc.com

In api repo pr 162, we move feature gates from registration repo to api repo, this pr is changed to use constants & variables in api repo

ivan-cai commented 2 years ago

@qiujian16 Plz review. Thanks!

qiujian16 commented 2 years ago

I think you would need to run make update?

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivan-cai, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ivan-cai commented 2 years ago

I think you would need to run make update?

/approve

@qiujian16 Thx, plz review. I have run make update and re-commit.

qiujian16 commented 2 years ago

/lgtm