search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

Support install addons in customized namespaces #256

Closed xuezhaojun closed 2 years ago

xuezhaojun commented 2 years ago

Signed-off-by: xuezhaojun zxue@redhat.com

Epic: https://github.com/stolostron/backlog/issues/23093

User-story: https://github.com/stolostron/backlog/issues/23929

xuezhaojun commented 2 years ago

/assign @skeeey

xuezhaojun commented 2 years ago

/assign @qiujian16

xuezhaojun commented 2 years ago

/assign @zhujian7

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuezhaojun To complete the pull request process, please ask for approval from qiujian16 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 2 years ago

/hold since we had some further discussion. This may not be needed.

xuezhaojun commented 2 years ago

/close Change to the approach that addons are responsible for creating ns they need.

openshift-ci[bot] commented 2 years ago

@xuezhaojun: Closed this PR.

In response to [this](https://github.com/open-cluster-management-io/registration/pull/256#issuecomment-1177830522): >/close >Change to the approach that addons are responsible for creating ns they need. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.