open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

Support V1beta1 CSR API Compatibility #258

Closed promacanthus closed 1 year ago

promacanthus commented 2 years ago

When the kubernetes version of hub cluster is less than 1.19, there is no v1 CSR API. The registration-controller running in the hub cluster will got the following error message.

E0627 02:27:32.103218       1 reflector.go:138] k8s.io/client-go@v0.23.0/tools/cache/reflector.go:167: Failed to watch *v1.CertificateSigningRequest: failed to list *v1.CertificateSigningRequest: the server could not find the requested resource

To solve this problem, we can enable compatibility with the v1beta1 CSR feature gates in the registration-controller.

qiujian16 commented 1 year ago

fixed

/close

openshift-ci[bot] commented 1 year ago

@qiujian16: Closing this issue.

In response to [this](https://github.com/open-cluster-management-io/registration/issues/258#issuecomment-1308857884): >fixed > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.