Closed zhujian7 closed 2 years ago
cc @elgnay @qiujian16
nit: It might be better to include installationNamespace
and addOnAgentRunningOutsideManagedCluster
when calculating the hash of the registrationConfig. Then we can keep the logic of the registration controller neat.
/approve
yes, I agree with @elgnay putting this into hash is better.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: elgnay, qiujian16, zhujian7
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Signed-off-by: zhujian jiazhu@redhat.com