search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

recreate the hub kubeconfig when addon deploy option changes #265

Closed zhujian7 closed 2 years ago

zhujian7 commented 2 years ago

Signed-off-by: zhujian jiazhu@redhat.com

zhujian7 commented 2 years ago

cc @elgnay @qiujian16

elgnay commented 2 years ago

nit: It might be better to include installationNamespace and addOnAgentRunningOutsideManagedCluster when calculating the hash of the registrationConfig. Then we can keep the logic of the registration controller neat.

elgnay commented 2 years ago

/approve

qiujian16 commented 2 years ago

yes, I agree with @elgnay putting this into hash is better.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elgnay, qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment