search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

add conversion webhook to convert clusterset api #272

Closed ldpliu closed 2 years ago

ldpliu commented 2 years ago

Signed-off-by: ldpliu daliu@redhat.com https://github.com/open-cluster-management-io/OCM/issues/67

ldpliu commented 2 years ago

/cc @qiujian16 @elgnay

ldpliu commented 2 years ago

@qiujian16 @elgnay I have added the e2e, please help to review it again. Thank you

qiujian16 commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldpliu, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elgnay commented 2 years ago

/lgtm