search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

stop to discovery addon when its managed cluster is not found #274

Closed skeeey closed 1 year ago

skeeey commented 1 year ago

Signed-off-by: Wei Liu liuweixa@redhat.com

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [skeeey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
skeeey commented 1 year ago

/cc @ldpliu please take a look at cluster set e2e part, thanks

ldpliu commented 1 year ago

/cc @ldpliu please take a look at cluster set e2e part, thanks

It looks good to me

qiujian16 commented 1 year ago

/lgtm