search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

Remove anonymous check from managedClusterCreatingController sync #299

Closed aii-nozomu-oki closed 1 year ago

aii-nozomu-oki commented 1 year ago

close https://github.com/open-cluster-management-io/registration/issues/298

Signed-off-by: aii-nozomu-oki h-nozomu.oki@inside.ai

skeeey commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aii-nozomu-oki, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [skeeey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
skeeey commented 1 year ago

/cc @qiujian16

It seems OK we check the unauth error and log it, but I forget why we check the anonymous user...

qiujian16 commented 1 year ago

i think it anonymous could happen if regisration is started but no bootstrap secret is provide yet? This PR looks fine, fallback does not help in this scenario.

/lgtm