search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

auto approve bootstrap csr #301

Closed skeeey closed 1 year ago

skeeey commented 1 year ago

/assign @qiujian16

qiujian16 commented 1 year ago

/approve

Anyone else you would need to review this PR. I think we should also refactor this controller to leverage generics as a followup

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16,skeeey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 1 year ago

/lgtm