search

open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

not delete addon hub-kubeocnfig during addon is deleting #315

Closed zhiweiyin318 closed 1 year ago

zhiweiyin318 commented 1 year ago

in some case, the addon agent needs hub-kubeconfig secret to do some cleanup works during the addon is deleting .so delete it after addon is deleted.

zhiweiyin318 commented 1 year ago

/hold

zhiweiyin318 commented 1 year ago

/assign @qiujian16 /assign @elgnay

zhiweiyin318 commented 1 year ago

/unhold

elgnay commented 1 year ago

/lgtm

qiujian16 commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)~~ [qiujian16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment