open-cluster-management-io / registration

hub / spoke registration controllers
Apache License 2.0
42 stars 58 forks source link

adding contextual logging #322

Closed nitishchauhan0022 closed 12 months ago

nitishchauhan0022 commented 1 year ago

Adding contextual logging in registration component Reference: #https://github.com/open-cluster-management-io/ocm/issues/191

For More Info: https://www.kubernetes.dev/blog/2022/05/25/contextual-logging/ https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nitishchauhan0022 Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/open-cluster-management-io/registration/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qiujian16 commented 1 year ago

thanks for your work, since we've moved the code to ocm repo already, https://github.com/open-cluster-management-io/registration#note-do-not-edit-any-file-in-this-repo. would you create a PR in ocm repo instead?

nitishchauhan0022 commented 1 year ago

ok

xuezhaojun commented 1 year ago

/assign @qiujian16 /assign @xuezhaojun

xuezhaojun commented 1 year ago

/unassign @qiujian16 /unassign @xuezhaojun

nitishchauhan0022 commented 1 year ago

hey @xuezhaojun this pr need to be opened to the main ocm repo, and since that contains other components as well, so i will open a combined pr with 1-2 days for all components in that repo. Hope, you understand have not been geeting time to work on it.

xuezhaojun commented 1 year ago

hey @xuezhaojun this pr need to be opened to the main ocm repo, and since that contains other components as well, so i will open a combined pr with 1-2 days for all components in that repo. Hope, you understand have not been geeting time to work on it.

Got it!Thanks!