Closed nitishchauhan0022 closed 12 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nitishchauhan0022 Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
thanks for your work, since we've moved the code to ocm repo already, https://github.com/open-cluster-management-io/registration#note-do-not-edit-any-file-in-this-repo. would you create a PR in ocm repo instead?
ok
/assign @qiujian16 /assign @xuezhaojun
/unassign @qiujian16 /unassign @xuezhaojun
hey @xuezhaojun this pr need to be opened to the main ocm repo, and since that contains other components as well, so i will open a combined pr with 1-2 days for all components in that repo. Hope, you understand have not been geeting time to work on it.
hey @xuezhaojun this pr need to be opened to the main ocm repo, and since that contains other components as well, so i will open a combined pr with 1-2 days for all components in that repo. Hope, you understand have not been geeting time to work on it.
Got it!Thanks!
Adding contextual logging in registration component Reference: #https://github.com/open-cluster-management-io/ocm/issues/191
For More Info: https://www.kubernetes.dev/blog/2022/05/25/contextual-logging/ https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md