Introduce a CoapMessage class/interface ?

[sbernard31]

I don't know if this is a good idea but I face some situation where I need to handle a coap request OR a coap (separated) response in a same way. This is not too surprising as from a CoAP RFC point of view all request and response are conceptually a CoAP Message.

In my case, I need the remote peer address and the transport context of the message. See :

• https://github.com/eclipse-leshan/leshan/blob/170d4095618e1371470ef27c61df5de4885b8610/leshan-tl-javacoap-core/src/main/java/org/eclipse/leshan/transport/javacoap/identity/DefaultCoapIdentityHandler.java#L27-L51
• https://github.com/eclipse-leshan/leshan/blob/170d4095618e1371470ef27c61df5de4885b8610/leshan-tl-javacoap-core/src/main/java/org/eclipse/leshan/transport/javacoap/identity/DefaultTlsIdentityHandler.java#L33-L47

[szysas]

Easy one would be to add helper method, would that be enough?

[sbernard31]

I'm not sure to see how it will looks like ?

[szysas]

Something like:

static InetSocketAddress getPeerAddress(Object coap) {
...

static TransportContext getTransportContext(Object coap) {
...

[sbernard31]

OK I get it but my question was more about having a kind of Parent class (e.g. CoapMessage) for CoapRequest, CoapResponse, SeparatedResponse. At first sight (maybe I'm wrong) I think this could make java-coap user code more elegant.

Regarding adding this static method, to be honest, I'm not sure will really makes my user code better. :thinking:

Anyway, maybe better to work first on https://github.com/open-coap/java-coap/issues/84 and see if you also need this kind of abstraction in java-coap code too ?