open-company / open-company-web

OpenCompany Web Application - Carrot web UI
https://github.com/open-company
Other
61 stars 9 forks source link

Onboard fields fix #1141

Closed bago2k4 closed 4 years ago

bago2k4 commented 4 years ago

Fix: the onboard form sometimes is updated after the user has started typing. That happens because the user data are loaded with some delay and once that happens the values from the server are inserted in the fields and the name one is focused.

To test:

bago2k4 commented 4 years ago

Code blocks (no syntax highlighting)

belucid commented 4 years ago

@bago2k4 I'm not seeing any change in behavior on this one.

I still get focus going back to name after starting typing in Why. Also Why isn't the active field to start after Slack login, though it should be.

bago2k4 commented 4 years ago

I removed the delay in focus now, before it was waiting 2.5 seconds before focusing on the first field of the view after the component was mounted. Now it focus on it right away so you shouldn't be able to type anything before.

I wouldn't change the focus, not sure how much it can take since we don't wait for all the data to be loaded when this view is shown and to know if user is using Slack or email i need more data.

Hope it makes sense