Add h1 and highlighter to text formatters.

open-company / open-company-web

OpenCompany Web Application - Carrot web UI

https://github.com/open-company

Other

61 stars 9 forks source link

Add h1 and highlighter to text formatters. #1148

Closed bago2k4 closed 4 years ago

bago2k4 commented 4 years ago

Card: https://trello.com/c/s7w5BfC1

NB: interaction service will remove highlight from the body (not the text, just the background color) since it doesn't accept mark elements right now. It changes with code-blocks PR

To test:

test H1 formatter
test H2 formatter
test Highlighter formatter
use a mix of them
make sure you can always type outside of a highlighter portion of text

bago2k4 commented 4 years ago

Format (H2, highlight)

belucid commented 4 years ago

@bago2k4 H2 icon is H1

bago2k4 commented 4 years ago

@belucid i think the icon bug you found on format PR is just cache. Before we had H1 but we were actually using an h2 tag in code, so the icon was named one way but represented the other thing. Try forcing refresh and it should be clear. I double checked on staging and i see the correct icons, at least in the ME context menu

Screenshot 2020-03-24 at 3 53 35 PM