Fix ocm issue 179, block in config yields invalid yaml

dee0sap commented 6 months ago

Description

Fixes https://github.com/open-component-model/ocm-project/issues/179

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[x] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Related Issue # 179
Closes # (179)
Fixes # (179)

Remove if not applicable

Screenshots

Added tests?

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help
[ ] Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

[ ] 📜 README.md
[x] 🙅 no documentation needed

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

morri-son commented 6 months ago

@mandelsoft , can you please takle a look at this proposal?

Skarlso commented 5 months ago

@dee0sap All you have to do is indent the value that you wish to substitute correctly.

We marshal values before doing anything this PR now fixes that in the sense that we don't marshal primitive values. That marshalling broke the syntax of the value that we are trying to insert. So we leave values alone. But we do marshal complex types like struct, pointer, maps, etc.

dee0sap commented 5 months ago

I think this PR is ready for whatever review process you guys have.

Skarlso commented 5 months ago

If anything breaks because of this, we'll iterate on a solution. ;)

open-component-model / ocm