It also fixes a bug where getting the credentials for a consumer provider lead to a deadlock or potentially an infinite recursion since we attempt to retrieve credentials to access the credential provider from the credential provider itself.
We might want to discuss the naming of the make targets. Thus, should make test run all tests including integration? Or should make test only run unit tests and make test-all (this is how I currently introduced it here) include integration tests?
Also, is it important that we have a make target which can run the integration tests exclusively (without including the unit tests)? This would require adding build tags to all tests.
What type of PR is this? (check all applicable)
[ ] 🍕 Feature
[ ] 🎇 Restructuring
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[x] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert
Related Tickets & Documents
Related Issue # (issue)
Closes # (issue)
Fixes # (issue)
Remove if not applicable
Screenshots
Added tests?
[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help
[ ] Separate ticket for tests # (issue/pr)
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
[ ] 📜 README.md
[ ] 🙅 no documentation needed
Checklist:
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
Description
Implement integration tests with vault.
It also fixes a bug where getting the credentials for a consumer provider lead to a deadlock or potentially an infinite recursion since we attempt to retrieve credentials to access the credential provider from the credential provider itself.
We might want to discuss the naming of the make targets. Thus, should
make testrun all tests including integration? Or shouldmake testonly run unit tests andmake test-all(this is how I currently introduced it here) include integration tests? Also, is it important that we have a make target which can run the integration tests exclusively (without including the unit tests)? This would require adding build tags to all tests.What type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: