search

open-condo-software / condo

Open source condominium management platform
MIT License
54 stars 23 forks source link

fix(condo): remove Popup Smart if there is no runtime configuration #4869

Closed paulo-rossy closed 2 weeks ago

paulo-rossy commented 3 weeks ago

I believe it is possible to omit adding a component if the corresponding variables, such as popupSmartConfig, are not provided

SavelevMatthew commented 3 weeks ago

Hi, thanks again for your contribution 🥳 🙏

The PR looks good and reasonable , the only thing left to do is to fix our CI (to make it pass on the PR from forks) to merge it.

I'm doing that at the moment and I think I'll be back with results to all your PRs by the end of the week. Sorry for the long wait 😢

SavelevMatthew commented 2 weeks ago

Hi, thanks again for your contribution 🥳 🙏

The PR looks good and reasonable , the only thing left to do is to fix our CI (to make it pass on the PR from forks) to merge it.

I'm doing that at the moment and I think I'll be back with results to all your PRs by the end of the week. Sorry for the long wait 😢

I'm happy to announce that we now know how to handle PRs and CI/CDs from forks 🥳 Please rebase your branch on the current master, after that the new CI will work and we will be able to accept your PRs ✅