open-condo-software / condo

Condo is an Open Source property management SaaS that allows users to manage tickets, resident contacts, properties, payment tracking, create invoices, and oversee a service marketplace, all while offering an extension system for mini-apps, making it an ideal platform for property management companies and those servicing shared properties.
MIT License
117 stars 27 forks source link

fix(condo): DOMA-9746 deeplink to mini-app after registration #5034

Closed tolmachev21 closed 3 months ago

Alllex202 commented 3 months ago

Seems strange to me, why all pages do accept next parameter now?

We have a flow: 1 - Register a user 2 - Create an organization

And the third step we need to add: 3 - go to the next page


We have a redirect to /tour from two places: 1) page / (under certain conditions) 2) After creating an organization (from component OrganizationSelect, under certain conditions)

It's really hard to manage when redirects can happen from different components at the most unexpected moment))

Simply redirecting to page X is not enough, you also need to prevent all redirects that may occur..

You can do something like this: do redirect to page X immediately after registration, but at the same time we need to tell the OrganizationSelect component that there is no need to use logic with redirects (for example using some flag in query)

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud