search

open-constructs / aws-cdk-library

Community-Driven CDK Construct Library
Apache License 2.0
44 stars 6 forks source link

chore: add some title options for PR lint #18

Closed go-to-k closed 3 weeks ago

go-to-k commented 3 weeks ago

Now there are only the semantic PR title options: feat, fix, and chore. So this PR adds some options to match the aws-cdk.

see: https://github.com/go-to-k/aws-cdk/blob/5347369fa11f4f11ab3893b9ac4c8467c5d514c3/tools/@aws-cdk/prlint/lint.ts#L706

hoegertn commented 3 weeks ago

LGTM but maybe we want to define when to use what in our contrib guide if we provide so many options?

go-to-k commented 3 weeks ago

That makes sense. I'll try to write something.

go-to-k commented 3 weeks ago

@hoegertn

How about my changing for the document a bit? Also, I erased the kinds I don't think I'll ever use.