search

open-constructs / aws-cdk-library

Community-Driven CDK Construct Library
Apache License 2.0
44 stars 6 forks source link

chore: sets minimum node.js version #19

Closed EYssel closed 2 weeks ago

EYssel commented 3 weeks ago

Fixes #16

This sets the minNodeVersion property in the projen config.

Node 18.20.2 was chosen as it is the latest LTS of Node.js 18 as of the creation of this PR.

Please feel free to discuss the usage of other versions below so that the best decision can be made.

It would be great to use 18.x as the minNodeVersion but as far as I can tell it is not possible using projen config.

EDIT:

It has been decided to use 18.0.0 until further notice

moltar commented 3 weeks ago

Is there a good reason to choose LTS?

Do we need any node features from this specific version?

I'd recommend setting it to the lowest realistic version we could support. Or even better, align with the cdk project.

go-to-k commented 3 weeks ago

It would be great to use 18.x as the minNodeVersion but as far as I can tell it is not possible using projen config.

(Except to talk about whether 18.x is better or 18.20.2 or some other version...)

If we want to do the same thing as 18.x, how about the following?

EYssel commented 3 weeks ago

It would be great to use 18.x as the minNodeVersion but as far as I can tell it is not possible using projen config.

(Except to talk about whether 18.x is better or 18.20.2 or some other version...)

If we want to do the same thing as 18.x, how about the following?

  • AwsCdkConstructLibrary in .projenrc.ts
  workflowNodeVersion: '18.x',
  minNodeVersion: '18.0.0',

Ah nice!

I was worried that it was changing the build.yml.

This solves it 😄