search

open-constructs / projen-pipelines

CDK pipelines using projen
Apache License 2.0
60 stars 2 forks source link

Honor workflowNodeVersion of project for generated workflows #106

Open hoegertn opened 2 months ago

hoegertn commented 2 months ago

Currently, when generating GitHub Actions workflows using projen-pipelines, the workflowNodeVersion is not being taken into consideration. This means that the workflows may not be using the specified Node.js version defined in the project configuration.

We need to update the code generation logic in projen-pipelines to honor the workflowNodeVersion specified in the project configuration. This will ensure that the generated workflows are using the correct Node.js version as intended by the project.

hoegertn commented 2 months ago

This might need some upstream changes to projen, as the workflow options are not accessible after creation

bigbohne commented 2 months ago

or allow the node version to be set like in projen with workflowNodeVersion: '20',

hoegertn commented 2 months ago

see https://github.com/projen/projen/pull/3855