PyCon Sprints - Adding Registration Page

open-contracting-archive / opendatacomparison

Django application for comparing datsets, built on Open Comparison

Other

5 stars 6 forks source link

PyCon Sprints - Adding Registration Page #13

Closed dlanger closed 10 years ago

dlanger commented 10 years ago

Works with Twitter and Google OAuth2.

TODO

[ ] @birdsarah - Create Twitter application for authentication (specs)
[ ] @birdsarah - Create Google application for authentication (specs)
[ ] @birdsarah - Create second set of Google and Twitter credentials to add into local_settings.py.dev to replace @dlanger's
[ ] Set up proper values for SOCIAL_AUTH_TWITTER_KEY, SOCIAL_AUTH_TWITTER_SECRET, SOCIAL_AUTH_GOOGLE_OAUTH2_KEY, and SOCIAL_AUTH_GOOGLE_OAUTH2_SECRET in local_settings.py.production
[x] Add links with appropriate images to registration page to /login/twitter and /login/google-oauth2

cohena commented 10 years ago

I'm working on creating the button links.

cohena commented 10 years ago

The social login keys and secrets are now pulled from: private_settings.SOCIAL_AUTH_TWITTER_KEY private_settings.SOCIAL_AUTH_TWITTER_SECRET private_settings.SOCIAL_AUTH_GOOGLE_OAUTH2_KEY private_settings.SOCIAL_AUTH_GOOGLE_OAUTH2_SECRET

We still need to change the dev keys to an appropriate other set of keys that we don't mind storing in source control (a different 'app' than the production keys).

birdsarah commented 10 years ago

Am I right in thinking this is done now?

cohena commented 10 years ago

Code wise, it's done. Production Google API and Twitter API apps need to be registered, and then their keys need to get put into the secret file for deployment.

birdsarah commented 10 years ago

Many thanks for this @dlanger and @cohena.

dlanger commented 10 years ago

High-five @cohena, nice working with you!