open-contracting-archive / toucan

A web interface to OCDS Kit and Flatten Tool
https://toucan.open-contracting.org
BSD 3-Clause "New" or "Revised" License
2 stars 5 forks source link

Add Split Packages and output file format options #104

Closed aguilerapy closed 4 years ago

aguilerapy commented 4 years ago

closes #81

aguilerapy commented 4 years ago

Work of @Ravf95 from UCA.

aguilerapy commented 4 years ago

closes #82

aguilerapy commented 4 years ago

Looks good, my only question is why the encoding/pretty print options are not available for other features like compile and to-json.

Those options are available for compile, or what do you mean?

imagen

to-jsonuses flattentool, we know that it accepts an encoding parameter, but the output file is always utf-8? flattentool indents all resulting files.

Also, I think we don't have a URL input option for this feature, should we use this PR to add it?

Already merged and having the input URL option.

imagen

romifz commented 4 years ago

Those options are available for compile, or what do you mean?

That's what I meant. I don't know what happened but I see the options now, maybe my browser was caching the old page.

to-json uses flattentool, we know that it accepts an encoding parameter, but the output file is always utf-8? flattentool indents all resulting files.

Perfect!