open-contracting-extensions / european-union

OCDS for the European Union
http://standard.open-contracting.org/profiles/eu/latest/en/
Apache License 2.0
9 stars 0 forks source link

techniques: Add fields about electronic workflows following the structure of BT-92, BT-743, BT-93 #50

Closed ColinMaudry closed 4 years ago

ColinMaudry commented 5 years ago

See also https://github.com/open-contracting-extensions/european-union/issues/5#issuecomment-517271339

ColinMaudry commented 5 years ago

The electronicInvoicing field would use the shared permissions code list (allowed, required, notAllowed).

ColinMaudry commented 5 years ago

These fields should go to a Contract terms extension: https://github.com/eForms/eForms/issues/322#issuecomment-517403313

ColinMaudry commented 5 years ago

Reopened until work starts on the Contract terms extension, as a reminder.

ColinMaudry commented 5 years ago

Here is the permission code list. We may need to make the subject more generic than "tenderers", since in some cases the field may apply to the buyer.

Code,Title,Description
required,Required,The tenderers are required to perform the activity.
allowed,Allowed,The tenderers are allowed to perform the activity.
notAllowed,Not allowed,The tenderers are not allowed to perform the activity.
ColinMaudry commented 5 years ago

Here is the schema part:

"hasElectronicPayment": {
          "title": "Electronic payment used",
          "description": "Whether electronic payment is used.",
          "type": [
            "boolean",
            "null"
          ]
      },
      "hasElectronicOrdering": {
          "title": "Electronic ordering used",
          "description": "Whether electronic ordering is used.",
          "type": [
            "boolean",
            "null"
          ]
      },
      "electronicInvoicing": {
          "title": "Electronic invoicing",
          "description": "Whether the buyer will require, allow or not allow electronic invoices.",
          "type": ["string", "null"],
          "openCodelist": false,
          "codelist": "permission.csv",
          "enum": [
            "required",
            "allowed",
            "notAllowed",
            null
          ]
      }
jpmckinney commented 5 years ago

A has* field implies a boolean value, but these are permission levels. I suggest removing the prefix has. Nevermind, I see the fields are indeed boolean!

We can change the code descriptions to "The activity is [required, allowed, not allowed]."

jpmckinney commented 5 years ago

So, first, I misread which fields used permission levels and which were boolean :) (I updated my earlier comment).

However, so far, we have used has* when there is another object that describes the attribute in more detail. Here, we just have a boolean attribute, which elsewhere we don't prefix with has, e.g. successiveReduction. Do you think it's likely that there will be e.g. an electronicPayment object in future? If not, should we remove the has prefix?

ColinMaudry commented 5 years ago

I think

ColinMaudry commented 5 years ago

OK to update the code descriptions to "The activity is [code]".

jpmckinney commented 5 years ago

Sounds good, re: has and OK to update code descriptions.

ColinMaudry commented 5 years ago

We have implemented these fields in the contractTerms extension.