open-contracting-extensions / european-union

OCDS for the European Union
http://standard.open-contracting.org/profiles/eu/latest/en/
Apache License 2.0
9 stars 0 forks source link

Finance.relatedLots : defined in lot or in finance schema? #67

Closed ColinMaudry closed 4 years ago

ColinMaudry commented 4 years ago

In the EU profile we instruct implementers to add a relatedLots array in the Finance object added in planning.budget.finance[].

Should we define Finance.relatedLots in the finance or in the lots schema?

jpmckinney commented 4 years ago

It's not perfect, but let's define it in Lots.

Otherwise, we'd need to make Lots a dependency of Finance, so that the $ref works.

ColinMaudry commented 4 years ago

Done in https://github.com/open-contracting-extensions/ocds_lots_extension/pull/32 (https://github.com/open-contracting-extensions/ocds_lots_extension/pull/32/commits/ef7232af7ef8439bd380c773a294eac10faf1109)