open-contracting-extensions / european-union

OCDS for the European Union
http://standard.open-contracting.org/profiles/eu/latest/en/
Apache License 2.0
9 stars 0 forks source link

F03 section V: /OBJECT_CONTRACT/OBJECT_DESCR/EU_PROGR_RELATED mapping is incorrectly indented #92

Closed duncandewhurst closed 3 years ago

duncandewhurst commented 3 years ago
  • Get the Organization object whose .name is ‘European Union’. If none exists yet:

    • Add a party
    • Set its .name to ‘European Union’
  • Add ‘funder’ to its .roles

  • Get the Finance object whose .description is the Identification of the project. If none exists yet:

    • Add a Finance object to the planning.budget.finance array
    • Map the Identification of the project to its .description
    • Set its .id incrementally
    • Set its .financingParty.name to ‘European Union’
    • Set its .financingParty.id to the party’s .id
    • Add the lot’s .id to its .relatedLots (F12, F13: Instead, do nothing)

Should be

  • Get the Organization object whose .name is ‘European Union’. If none exists yet:

    • Add a party
    • Set its .name to ‘European Union’
  • Add ‘funder’ to its .roles

  • Get the Finance object whose .description is the Identification of the project. If none exists yet:

    • Add a Finance object to the planning.budget.finance array
    • Map the Identification of the project to its .description
    • Set its .id incrementally
    • Set its .financingParty.name to ‘European Union’
    • Set its .financingParty.id to the party’s .id
  • Add the lot’s .id to its .relatedLots (F12, F13: Instead, do nothing)

jpmckinney commented 3 years ago

What exactly is changed? Visually comparing big blocks of nearly identical text isn't easy :)

duncandewhurst commented 3 years ago

The final bullet is one less level indented, otherwise, there's no action when the Finance object whose .description is the Identification of the project already exists.

jpmckinney commented 3 years ago

Fixed in staging: https://standard.open-contracting.org/staging/profiles/eu/latest/en/forms/F01/#II.2.13

I'll wait to deploy until issues are closed / aren't being created regularly.