search

open-contracting-extensions / public-private-partnerships

OCDS for Public Private Partnerships (PPPs)
http://standard.open-contracting.org/profiles/ppp/latest/en/
Other
5 stars 3 forks source link

Restore buyer and suppliers fields #236

Closed jpmckinney closed 3 years ago

jpmckinney commented 3 years ago

These are renamed to publicAuthority and preferredBidders. This makes OCDS for PPPs data unnecessarily incompatible with OCDS data. The original terms are inappropriate, but this needs to be fixed in an OCDS 2.0, not in a profile. For OCDS 1.2, the fix is to broaden the definitions of buyer and suppliers, while retaining the terms.

jpmckinney commented 3 years ago

cc @duncandewhurst

duncandewhurst commented 3 years ago

Agreed, sounds good.

jpmckinney commented 3 years ago

@duncandewhurst Since OCDS for PPPs is relevant to a few active implementers, and since you might be making changes to close #238, could you take on this issue, #237 and ideally #217 ?

duncandewhurst commented 3 years ago

Sure, should I prioritise those above 1.2 issues?

jpmckinney commented 3 years ago

Yes, looks like Matt, Kadie and Charlie have taken on enough 1.2 issues for now.

duncandewhurst commented 3 years ago

@jpmckinney a couple of questions on your preferred approach:

jpmckinney commented 3 years ago

Should we remove publicAuthority and preferredBidders completely, or should we deprecate them?

Since the profile isn't 1.0 but is beta, I think better to remove.

Should we also remove/restore the associated codes in partyRole.csv?

Yes, good catch.