search

open-contracting-extensions / public-private-partnerships

OCDS for Public Private Partnerships (PPPs)
http://standard.open-contracting.org/profiles/ppp/latest/en/
Other
5 stars 3 forks source link

Add codes to documentType.csv, instead of replacing it #253

Closed jpmckinney closed 3 years ago

jpmckinney commented 3 years ago

https://github.com/open-contracting-extensions/ocds_ppp_extension/blob/master/codelists/documentType.csv

This contains codes from OCDS, other extensions, etc. It is a maintenance challenge, since any improvements, corrections or deprecations of those codes in OCDS and extensions will not be reflected here.

For example, in OCDS the description of 'contractSchedule' had drifted toward 'contractAnnexe', such that 'contractSchedule' is deprecated: https://github.com/open-contracting/standard/issues/870

Instead of replacing the codelist, the PPP extension should only add the codes that are unique to that extension.

jpmckinney commented 3 years ago

FYI @ColinMaudry

duncandewhurst commented 3 years ago

Once we've merged https://github.com/open-contracting-extensions/ocds_ppp_extension/pull/15 then we need to run build_profile.py to close this issue.

jpmckinney commented 3 years ago

I ran make clean_dist first, to clear out old files (documentType.csv and -partyRole.csv). #262