search

open-contracting / cardinal-rs

Measure red flags and procurement indicators using OCDS data
https://cardinal.readthedocs.io
MIT License
9 stars 3 forks source link

Consider support for string "amount" values #13

Closed jpmckinney closed 1 year ago

jpmckinney commented 1 year ago

We expect this to be a very rare occurrence.

The OCDS implementation in Belarus had a case where a number in the source system was badly formatted, and the publication therefore published it as a string.

However, in that case, we won't have much luck converting to float - making assumptions about whether comma or period is used as the decimal point, etc. might just lead to incorrect results.

Leaving this issue open for now, but I think it might be wontfix.

jpmckinney commented 1 year ago

We could add a warning if the amount is a string – but per #29 we don't want to warn about something unless the user has an option available to correct it.

jpmckinney commented 1 year ago

I don't see a way to fix this quality issue, unless there is a user who is very confident about the pattern of errors (e.g. comma is always the decimal point). I think it also only came up once (in a private publication).