open-contracting / cove-oc4ids

OC4IDS Data Review Tool
Other
0 stars 2 forks source link

Field coverage visualisation: calculation #98

Closed pindec closed 3 years ago

pindec commented 3 years ago

The OC4IDS field coverage calculation should align with Pelican's OCDS field coverage calculation to avoid confusing publishers:

See also:

pindec commented 3 years ago

Noting that there are many ways to calculate coverage.

For example see related discussion on multiple levels of coverage views in OCDS.

jpmckinney commented 3 years ago

This issue describes two types of calculation: the indicator (first bullet) and the aggregation (other bullets).

In terms of implementation, the indicator calculation might be what is stored, whereas the aggregation calculation might be performed by the visualization, or stored in a second phase. This would make it easier to change the visualization later (per Charlie's points on intermediate and high-level coverage).

Here is Pelican's indicator calculation (same as described in Charlie's first bullet, but with more specific error messages for Pelican's use case).

The indicator calculations are then aggregated into reports. This is just as FYI as the calculation is straightforward.

And here is part of Pelican's frontend. Pelican uses Vue, whereas I guess CoVE might use Bootstrap accordions. Again, there's nothing fancy. The CSS might be reusable, though, if desired.

pindec commented 3 years ago

@jpmckinney Do you have any preferences on CoVE using Bootstrap and/or Vue?

jpmckinney commented 3 years ago

CoVE already uses Boostrap. I suspect switching to Vue would consume all available time.

duncandewhurst commented 3 years ago

Done in https://github.com/OpenDataServices/lib-cove/pull/89