open-contracting / credere-backend

A tool that facilitates the participation of Micro, Small, and Medium businesses (MSMEs) in the Colombian public procurement market.
https://credere.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Avoid sa_column where possible #239

Closed jpmckinney closed 1 month ago

jpmckinney commented 10 months ago

It can cause programmer errors like in #235.

jpmckinney commented 9 months ago

When making changes to Decimal in #238, we had changed the type annotation from Decimal to our custom type FLOAT_DECIMAL https://github.com/open-contracting/credere-backend/pull/238/commits/56ea76a2ff1919637458d5f4b8e5e017eaf1856a, based on this documentation: https://docs.pydantic.dev/latest/api/standard_library_types/#decimaldecimal

Relevant comments: