Closed jpmckinney closed 1 month ago
When making changes to Decimal in #238, we had changed the type annotation from Decimal
to our custom type FLOAT_DECIMAL
https://github.com/open-contracting/credere-backend/pull/238/commits/56ea76a2ff1919637458d5f4b8e5e017eaf1856a, based on this documentation: https://docs.pydantic.dev/latest/api/standard_library_types/#decimaldecimal
Relevant comments:
It can cause programmer errors like in #235.
DECIMAL
: https://sqlmodel.tiangolo.com/advanced/decimal/#decimals-in-sqlmodelDateTime(timezone=True)
: https://github.com/tiangolo/sqlmodel/issues/539JSON
https://github.com/tiangolo/sqlmodel/issues/42 (<class 'dict'> has no matching SQLAlchemy type
ifsa_type=JSON
is omitted)DateTime(timezone=False)
(maybe better to stay consistent withDateTime(timezone=True)
)