chore: Rename "background" to "commands" where relevant, to avoid confusion with FastAPI background tasks. Organize code accordingly.

open-contracting / credere-backend

A tool that facilitates the participation of Micro, Small, and Medium businesses (MSMEs) in the Colombian public procurement market.

https://credere.readthedocs.io

BSD 3-Clause "New" or "Revised" License

5 stars 0 forks source link

chore: Rename "background" to "commands" where relevant, to avoid confusion with FastAPI background tasks. Organize code accordingly. #261

Closed jpmckinney closed 6 months ago

jpmckinney commented 6 months ago

Also:

Rename _get_or_create_borrower to _create_or_update_borrower
Add _from_source to functions that call data_access

jpmckinney commented 6 months ago

Sorry, ignore the request.

yolile commented 6 months ago

@jpmckinney do we need to update the cron jobs we have?

jpmckinney commented 6 months ago

I don't think so - they run /usr/bin/docker compose --progress=quiet run --rm cron python -m app.commands <command>, and I haven't renamed commands or moved the app.commands module.

yolile commented 6 months ago

Ah, the changes made to https://github.com/open-contracting/credere-backend/pull/261/files#diff-e6f90196d42bcd0142972be0372e95f81d2d010bf550d804b84f5dcf7f4f173f confused me, thanks!

jpmckinney commented 6 months ago

Ah, yeah, I deleted the sample crontab because that's purely deployment related, and we don't use those commands, exactly.