feat: rollback confirmation of credit option

open-contracting / credere-backend

A tool that facilitates the participation of Micro, Small, and Medium businesses (MSMEs) in the Colombian public procurement market.

https://credere.readthedocs.io

BSD 3-Clause "New" or "Revised" License

5 stars 0 forks source link

feat: rollback confirmation of credit option #267

Closed nahu closed 5 months ago

nahu commented 6 months ago

Endpoint to call in the back button of Upload Documents Page

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8158694913

Details

5 of 23 (21.74%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 86.714%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
app/routers/guest/applications.py	3	21	14.29%
<!--	Total:	5	23	21.74%	-->

Totals
Change from base Build 7875989668:	-0.7%
Covered Lines:	1971
Relevant Lines:	2273

💛 - Coveralls

yolile commented 6 months ago

@nahu I see we already have a /applications/rollback-select-credit-product endpoint. What is the difference between that one and this one?

nahu commented 6 months ago

After the Calculator screen, there are two steps until the documents upload, first, it is the selection of the credit option and then there is confirmation, that is why a two-step rollback is needed.

Those fields that you mentioned are missing are the ones that are set in the selection step. I'll add the new Application Action suggested.

yolile commented 5 months ago

@nahu any updates on this?