open-contracting / credere-backend

A tool that facilitates the participation of Micro, Small, and Medium businesses (MSMEs) in the Colombian public procurement market.
https://credere.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Why was quote_plus removed in b0df3dbc? #315

Closed jpmckinney closed 1 month ago

jpmckinney commented 1 month ago

A URL with spaces is not valid (the requests library is able to handle it, though).

What was the problem with keeping quote_plus? b0df3dbc

Edit: I think the previous logic needed to be applied before constructing the contract_url in a77521bc – otherwise, we have a partially quoted params string, which probably causes double encoding when requests fixes the remaining spaces.

quoting was originally used to escape characters like & 67ca9ab