open-contracting / credere-backend

A tool that facilitates the participation of Micro, Small, and Medium businesses (MSMEs) in the Colombian public procurement market.
https://credere.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

chore: Raise SourceFormatError instead of SkippedAwardError when outside handle_skipped_award #317

Closed jpmckinney closed 1 month ago

jpmckinney commented 1 month ago

fixes #311

This fix assumes that we don't want to do the following instead:

Or, if we want to allow processing to continue, we need to add handle_skipped_award inside the for-loop in _get_awards_from_data_source. That said, if keys are missing, it might be a sign that the response format has changed, in which case we would expect all awards to fail.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10333964690

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
app/commands.py 1 2 50.0%
<!-- Total: 2 3 66.67% -->
Totals Coverage Status
Change from base Build 10333825387: 0.005%
Covered Lines: 2036
Relevant Lines: 2355

💛 - Coveralls