Message instance not created from some send methods

[jpmckinney]

• update_apps_send_notifications endpoint
  • send_notification_new_app_to_fi (NEW_APPLICATION_FI)
  • send_notification_new_app_to_ocp (NEW_APPLICATION_OCP)
• change_email endpoint
  • send_new_email_confirmation_to_sme calls send_new_email_confirmation, which only returns one out of two message IDs (the message to the new address, but not the message to the old address)

I don't know if these omissions are by design - we log every other message, with the exception of those above and these these two below, which are related to OCP/lender user accounts, so makes sense they are not tracked:

• admin_create_user (mail.send_mail_to_new_user)
• reset_password (mail.send_mail_to_reset_password)

[jpmckinney]

Having read more code, I think these Message instances would just be noise (and duplicative).