Closed jpmckinney closed 4 weeks ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
app/utils/statistics.py | 37 | 44 | 84.09% | ||
<!-- | Total: | 37 | 44 | 84.09% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
app/utils/statistics.py | 1 | 86.67% | ||
app/commands.py | 3 | 93.89% | ||
<!-- | Total: | 4 | --> |
Totals | |
---|---|
Change from base Build 10374713403: | -0.5% |
Covered Lines: | 1871 |
Relevant Lines: | 2177 |
I think we should also change https://github.com/open-contracting/credere-backend/blob/main/app/routers/statistics.py to not check the database and calculate and return the statistics instead
And then we could delete the update_statistics
commands and Statistics table...
I think we should also change https://github.com/open-contracting/credere-backend/blob/main/app/routers/statistics.py to not check the database and calculate and return the statistics instead
And then we could delete the update_statistics commands and Statistics table...
Sure, but let's do that in another PR, this one is a big changeset already.
delete the ... Statistics table
The table does keep a history of statistics as of each date – not sure if this was a requirement.
Okay to merge on my end.
fixes #331 e41c54e fixes #334 91063d8 fixes #335 c4239a0 fixes #336 3128206 fixes #337 e1f9ed8 fixes #338 437e8c3 fixes #339 1cc4542
Values changed in output: